Revert breaking size changes#4693
Merged
Merged
Conversation
…iven" This reverts commit c99f15c.
This reverts commit ed29203.
brandonwillard
force-pushed
the
revert-shape-args
branch
from
65b2ffb to
08754cd
Compare
Member
|
Thanks @brandonwillard, just to make sure, is this literally a 100% reversion to the pre-#4625 state or does it introduce any other changes? |
Contributor
Author
Yes, and resolutions to conflicts caused by subsequent changes to code touched by #4625. I believe the latter was only relevant to the most recently merged PR #4684. That's the main reason for doing this reversion ASAP: it will only get harder to revert, track, and/or repair the problems caused by #4625 if we keep merging things into |
twiecki
approved these changes
May 14, 2021
Member
|
Let's wait with merging until I fixed the tests in #4696. |
Member
Contributor
Author
|
I asked @twiecki right before merging this. |
Member
|
Yes I said he should merge as it was holding up other stuff.
…On Fri, May 14, 2021, 20:43 Brandon T. Willard ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/5894642/118314110-f6775380-b4f3-11eb-818e-1406e01c7338.png>
@brandonwillard <https://github.com/brandonwillard>
I asked @twiecki <https://github.com/twiecki> right before merging this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4693 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGA2HDXAEUPUG63GMV3TNVVMXANCNFSM443HPFNA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the
size-related breaking changes andModel/Distributiondesign issues introduced by #4625.Closes #4662.